add indents to cbuilder #24418
Merged
add indents to cbuilder #24418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
pushed a commit
that referenced
this pull request
Nov 8, 2024
This loses indents in codegen for now, another PR includes changes to add indents to `Builder` itself rather than tracking `TBlock`: #24418
metagn
force-pushed
the
cbuilder-block-indents
branch
from
bfd4f99 to
fb0c50d
Compare
|
Please rebase. |
metagn
force-pushed
the
cbuilder-block-indents
branch
from
fb0c50d to
41ddeeb
Compare
|
Done |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #24416
Really only shows benefits if most of ccgstmts is done as in #24399/#24420, but the diff is entirely in cbuilder